Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): Adds map declaration analysis to concerto-analysis #691

Merged
merged 15 commits into from
Aug 23, 2023

Conversation

jonathan-casey
Copy link
Member

Description

Extends the concerto-analysis API to compare two versions of a model which may or may not contain map declarations, and determine if those versions are compatible.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format

@jonathan-casey jonathan-casey requested a review from a team August 22, 2023 20:29
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Ertugrul's comments before merging.

@jonathan-casey jonathan-casey merged commit 09b3d15 into main Aug 23, 2023
@jonathan-casey jonathan-casey deleted the jonathan/map_analysis branch August 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants